-
Notifications
You must be signed in to change notification settings - Fork 79
openshift: Properly filter unsupported grub config #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6991aeb
to
0d22e08
Compare
Example butane configuration for testing unsupported grub config
|
Hum, if we do this correctly, the docs for the GRUB part should disappear from the openshift specs. |
i.e. we should not need the workaround in https://github.com/coreos/butane/blob/main/internal/doc/butane.yaml#L357 anymore |
0d22e08
to
d4aa25d
Compare
I am a bit confused on that area. As far as I can understand, openshift 4.20.0-experimental has the |
It's only implemented in this experimental version of the spec. For all the others, it should not be mentioned in the docs at all. |
I tried things in main...travier:butane:ocp-grub-unsupported-wip but that's not correct either. |
We need to find the correct way to filter it completely from the docs as well as have it fail during validation. |
WIP as this fails tests but I don't yet understand why