Skip to content

Conversation

travier
Copy link
Member

@travier travier commented Jul 12, 2024

WIP as this fails tests but I don't yet understand why

@Roshan-R Roshan-R force-pushed the ocp-grub-unsupported branch from 6991aeb to 0d22e08 Compare May 28, 2025 07:55
@Roshan-R Roshan-R marked this pull request as ready for review May 28, 2025 07:59
@Roshan-R
Copy link
Contributor

Example butane configuration for testing unsupported grub config

variant: openshift
version: 4.18.0
metadata:
  name: test-grub-block
  labels:
    machineconfiguration.openshift.io/role: worker
grub:
  users:
    - name: root
      password_hash: "$6$abcd"  # Just a dummy hash

@travier
Copy link
Member Author

travier commented May 28, 2025

Hum, if we do this correctly, the docs for the GRUB part should disappear from the openshift specs.

@travier
Copy link
Member Author

travier commented May 28, 2025

i.e. we should not need the workaround in https://github.com/coreos/butane/blob/main/internal/doc/butane.yaml#L357 anymore

@Roshan-R Roshan-R force-pushed the ocp-grub-unsupported branch from 0d22e08 to d4aa25d Compare May 28, 2025 13:16
@Roshan-R
Copy link
Contributor

Hum, if we do this correctly, the docs for the GRUB part should disappear from the openshift specs.

I am a bit confused on that area. As far as I can understand, openshift 4.20.0-experimental has the translateUserGrubCfg function to handle the $.grub path. So shouldn't that warrant it to be documented in internal/doc/butane.yaml? Or am I missing something obvious.

@travier
Copy link
Member Author

travier commented May 30, 2025

It's only implemented in this experimental version of the spec. For all the others, it should not be mentioned in the docs at all.

@travier
Copy link
Member Author

travier commented May 30, 2025

I tried things in main...travier:butane:ocp-grub-unsupported-wip but that's not correct either.

@travier
Copy link
Member Author

travier commented May 30, 2025

We need to find the correct way to filter it completely from the docs as well as have it fail during validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-notes This PR does not need release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants