Deleting instances with empty password fails

[pacman82]

Server returns status failed (in http body). Msg is:

Could not connect to postgres instance: fe_sendauth: no password supplied

http code is 200 ok.

As it stands now, one can create instances with an empty password, but not delete them.

[sebastianneubauer]

To me this looks like an empty password is not valid, at least the error message comes directly from the postgres login using psycopg
What about checking explicitely for an nonempty passwors at creation time of the instance?
Opinions?
One thing to consider might be: Is this backend dependent? it might be totally valid for a local postgres to accept empty passwords?

[theMarix]

In Postgres 9 the empty string is a valid password. The error in this case stems from the client library. It seems Psycopg2 does not even attempt password authentication in this case. A wrong password gives a different error message.
However, Postgresql 10 will disable the password if it is an empty string. Given that this will give us an unusable database anyways then we should just completely prevent the creation of databases with empty strings as password. It's a bad idea anyhow.

[pacman82]

@theMarix Thank you.