fix list views with parameters in last path segment not named "list" views

[terencehonles]

This fixes the auto generated operation keys and operation ID. For list views which have a parameter in their last path segment.

[JoelLefkowitz]

Thanks for digging into this @terencehonles, looks really good. I'd like to have a unit test for this to validate the behaviour when there is and isn't a detail attribute before we merge. Could we also move the if method.lower() != "get": clause into the previous if statement so it's a little easier to follow?

[terencehonles]

Thanks for digging into this @terencehonles, looks really good. I'd like to have a unit test for this to validate the behaviour when there is and isn't a detail attribute before we merge.

Isn't this what the reference schema is testing? I effectively fixed the test with https://github.com/axnsan12/drf-yasg/pull/917/files#diff-741bf237457101c6d297e385e111f8b5477fbbd9369c53a05c08c64e307d0e17

See:

• drf-yasg/testproj/snippets/urls.py

  Line 8 in 379dd8a

  path("views/<int:snippet_pk>/", views.SnippetViewerList.as_view()),

• drf-yasg/testproj/snippets/views.py

  Lines 105 to 131 in 379dd8a

  	class SnippetViewerList(generics.ListAPIView):
  	"""SnippetViewerList classdoc"""
  	serializer_class = SnippetViewerSerializer
  	pagination_class = PageNumberPagination
  	parser_classes = (FormParser, CamelCaseJSONParser, FileUploadParser)
  	renderer_classes = (CamelCaseJSONRenderer,)
  	swagger_schema = CamelCaseOperationIDAutoSchema
  	lookup_url_kwarg = "snippet_pk"
  	def get_object(self):
  	queryset = Snippet.objects.all()
  	# Perform the lookup filtering.
  	lookup_url_kwarg = self.lookup_url_kwarg or self.lookup_field
  	filter_kwargs = {self.lookup_field: self.kwargs[lookup_url_kwarg]}
  	obj = get_object_or_404(queryset, **filter_kwargs)
  	# May raise a permission denied
  	self.check_object_permissions(self.request, obj)
  	return obj
  	def get_queryset(self):
  	return SnippetViewer.objects.filter(snippet=self.get_object())

The detail attribute comes from the viewset handling, and this is a view class.

Could we also move the if method.lower() != "get": clause into the previous if statement so it's a little easier to follow?

Done

[terencehonles]

@JoelLefkowitz I updated this to include the commit that fixed the CI

[terencehonles]

Thanks for looking at the other PR and merging in master @JoelLefkowitz. It looks like this is still green, is there anything blocking merging this?

[JoelLefkowitz]

Looks all good, thanks @terencehonles 🥳