fix lint errors with type comparison #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll see if I can update this PR sometime soon, but may not get to it this weekend |
terencehonles
force-pushed
the
fix-lint-errors-with-type-comparison
branch
from
b66af4c to
a12c61e
Compare
|
I've rebased this after #897 @JoelLefkowitz |
|
It does look like these are not flagged by the linter anymore so we could drop this PR, but using |
terencehonles
force-pushed
the
fix-lint-errors-with-type-comparison
branch
from
a12c61e to
91403b4
Compare
|
@JoelLefkowitz do you mind if we get this small PR in? They don't seem to be lint errors anymore, but they should be using |
JoelLefkowitz
added
1.21.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some lint errors that appeared when updating #840 since the linting rules do not seem to be pinned or changed since the last run.