handle errors rendering with TemplateHTMLRenderer #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an `OPTIONS` request to the API page which will return a successful response, but the `TemplateHTMLRender` will not be prepared to render it since there is no template name provided in either the view or response [1]. [1]: https://github.com/encode/django-rest-framework/blob/f0a5b958a134e8cd94e3ef3263e8fa623ac9b82f/rest_framework/renderers.py#L178-L189
terencehonles
commented
Sep 24, 2021
| # see https://github.com/axnsan12/drf-yasg/issues/58 | ||
| return TemplateHTMLRenderer().render(swagger, accepted_media_type, renderer_context) | ||
| except ImproperlyConfigured: | ||
| # Fall back to using eg '404 Not Found' |
There was a problem hiding this comment.
Stolen from the error handling code path https://github.com/encode/django-rest-framework/blob/f0a5b958a134e8cd94e3ef3263e8fa623ac9b82f/rest_framework/renderers.py#L199-L202
terencehonles
deleted the
handle-errors-rendering-with-TemplateHTMLRenderer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an
OPTIONSrequest to the API page which will return a successful response, but theTemplateHTMLRenderwill not be prepared to render it since there is no template name provided in either the view or response.