Add Virtualization to Redoc #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup beautiful indeed |
|
Nice work! |
firdausunit4
approved these changes
Nov 8, 2024
kandaliakiki
reviewed
Nov 8, 2024
Thank you. |
kandaliakiki
reviewed
Nov 8, 2024
kandaliakiki
reviewed
Nov 8, 2024
kandaliakiki
reviewed
Nov 8, 2024
|
Latest results: |
|
Brilliant work ! |
alfinm01
reviewed
Nov 8, 2024
| <div ref={scrollableRef} style={{ height: '100dvh', width: '100%', overflowY: 'auto' }}> | ||
| <div | ||
| style={{ | ||
| height: virtualizer.getTotalSize() + 257, |
There was a problem hiding this comment.
What is this specific number means?
Will this cause an issue in the web's dimension responsiveness? i.e. if we open the API docs in smaller devices
| top: 0, | ||
| left: 0, | ||
| width: '100%', | ||
| transform: `translateY(${virtualItem.start + 500}px)`, |
There was a problem hiding this comment.
Same as my comment above.
Will the + 500 cause an issue in the web's dimension responsiveness? i.e. if we open the API docs in smaller devices
|
Sorry, just realized my comment is on pending review, not submitted yet lmao |
|
Thanks Alfin. Yes it was the dirts I haven't cleaned up during the development (did some trial and error). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit Tests
Demo Video
Sent on MS Teams.