Skip to content

Conversation

BrandonStalnaker
Copy link
Collaborator

Summary

  • Timing issues led to user attributes not being set when an identify needed called within the selectPlacements method. Changing the dispatch to the message queue guarantees that all the setUserAttributes are completed before the kit code is called and thankfully in 'attemptToLogEventToKit' of 'MPKitContainer.mm' (which comes after that dispatch in the mp core code) we dispatch back to the main queue as needed.

The change to 'MPKitContainer.mm' is just to make debugging with breakpoints easier.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with example app on simulator

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker changed the title fix: Make selectPlacement Use Mesaage Queue fix: Make selectPlacement Use Message Queue Jun 16, 2025
@BrandonStalnaker BrandonStalnaker merged commit ce1a284 into development Jun 17, 2025
28 of 39 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/SQDSDKS-7335-Dispatch-SelectPlacement-To-Message-Queue branch June 17, 2025 12:53
mparticle-automation added a commit that referenced this pull request Jun 17, 2025
## [8.34.1](v8.34.0...v8.34.1) (2025-06-17)

### Bug Fixes

* Make selectPlacement Use The Message Queue ([#366](#366)) ([ce1a284](ce1a284))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.34.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants