Skip to content

Conversation

jamesnrokt
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Multiple select placements calls made due to completion block
  • This PR addresses it by only returning if user.identities does not match email
  • Tests refactored as mocks were affecting tests in other parts of code now they stop mocking after each test

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-requested a review June 11, 2025 12:44
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! LGTM

@BrandonStalnaker BrandonStalnaker merged commit f8d3ff8 into mParticle:development Jun 11, 2025
19 of 27 checks passed
mparticle-automation added a commit that referenced this pull request Jun 12, 2025
# [8.33.0](v8.32.0...v8.33.0) (2025-06-12)

### Features

* Multiple select placements calls made ([#361](#361)) ([f8d3ff8](f8d3ff8))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants